Re: [PATCH v3 3/8] mingw: make failures to unlink or move raise a question

Johannes Schindelin [off-list ref] writes:

quoted

quoted

@@ -129,6 +130,78 @@ static inline int is_file_in_use_error(DWORD errcode)
       return 0;
 }

+static int read_yes_no_answer()

Perhaps "static int read_yes_no_answer(void)" for portability?

LOL. This file is called compat/mingw.c... :-)

I had the same reaction.  Maybe MinGW will get a different compiler
someday ;-)

But I have no objection to stay with the convention of the rest of Git. 
Nobody needs to convince me that consistency is good.

I recall there are a few old-style declaration in compat/ directory,
especially in borrowed code like nedmalloc/ and possibly regex/, and
I am not so sure if we want to touch them.

I'll leave this up to msysgit folks.

Thanks.