Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] logging branch deletion to help recovering from mistakes

From: Štěpán Němec <hidden>
Date: 2016-06-15 22:50:11

Junio C Hamano [off-list ref] writes:

[...]

Just two cosmetic nits I noticed:
quoted hunk
diff --git a/Documentation/config.txt b/Documentation/config.txt
index d82c0da..bdf90eb 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -351,6 +351,12 @@ This value is true by default in a repository that has
 a working directory associated with it, and false by
 default in a bare repository.
 
+core.logRefDeletion::
+	Enable logging of eletion of refs (e.g. branches), allowing `git
                          ^^^^^^^

[...]
quoted hunk
diff --git a/refs.c b/refs.c
index e3c0511..afdd634 100644
--- a/refs.c
+++ b/refs.c
[...]
-	/* removing the loose one could have resurrected an earlier
-	 * packed one.  Also, if it was not loose we need to repack
-	 * without it.
-	 */
Could also the first sentence start with a capital letter?

[...]
+		if (!(delopt & REF_NODEREF))
+			lock->lk->filename[i] = '.';
+	}
+	/*
+	 * removing the loose one could have resurrected an earlier
+	 * packed one.  Also, if it was not loose we need to repack
+	 * without it.
+	 */
Same here.

Thank you,

  Štěpán
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help