Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCHv2 4/7] web--browse: support opera, seamonkey and elinks

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:50:10

Giuseppe Bilotta [off-list ref] writes:
-w3m|links|lynx|open)
+w3m|elinks|links|lynx|open)
 	eval "$browser_path" "$@"
 	;;
 start)
 	exec "$browser_path" '"web-browse"' "$@"
 	;;
-dillo)
+opera|dillo)
 	"$browser_path" "$@" &
 	;;
Not a complaint on your patch, but is there a reason we say "eval", "exec"
and "(nothing)" in these three case arms?

The above makes the interpretation of $browser_path and $@ inconsistent
between lynx family codepath (which would apply $IFS to find the browser)
and dillo and start family codepath (which would not), and I am wondering
if that difference is intended.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help