Thread (13 messages) flat view 13 messages, 4 authors, 2016-06-15

Re: [PATCHv2 7/7] web--browse: look at the BROWSER env var

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:50:10

Jonathan Nieder wrote:
Giuseppe Bilotta wrote:
quoted
--- a/git-web--browse.sh
+++ b/git-web--browse.sh
@@ -138,6 +138,51 @@ then
[...]
quoted
+if test -z "$browser" -a -n "$BROWSER"; then
+	OLDIFS="$IFS"
+	IFS=:
[...]
quoted
+	IFS="$OLDIFS"
Micronit: on some shells (e.g., old ash[1]), IFS starts out unset if
it hasn't been inherited in the environment.
Of course, we are using this idiom in a few places already, so that
can be saved for another topic.  Sorry for not checking sooner.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help