Re: [PATCH 0/3] gitk: improve dark background
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:50:07
David Fries [off-list ref] writes:
I submitted the 'gitk: improve dark background' patch to the list, made improvements based on the feedback, and submitted the result two weeks ago without any further feedback. I put my changes off of master, but gitk is identical in both maint and master. Can you pull the changes?
I saw the patch, but I didn't really look at it (I don't use gitk very often, and I am an old-fashioned "darker ink on lighter sheet" user so I wouldn't be a good judge on your change). I don't take patches to gitk or git-gui directly to my tree. Please Cc: the maintainer of that part of the system (Paulus, whom I am Cc'ing this message) the next time. Thanks.
branch gitk_colors from git://gitorious.org/~dfries/git/dfriess-git-mainline.git This e-mail is also a replay to the last posting of the patches. On Wed, Nov 10, 2010 at 10:59:54PM -0600, David Fries wrote:quoted
The gitk preferences allow for the user to select different colors. The setui is even set to dynamically detect how light or dark the background is and set the selection color to be the opposite, but there are a few other color selections that don't currently work with a dark background such as the black outlines. This patch improves the color selection. In some cases it just needs to use the current forground color, other places it is more complicated. ...