Re: What's cooking in git.git (Nov 2010, #03; Wed, 24)

On Thu, Nov 25, 2010 at 11:35, Erik Faye-Lund [off-list ref] wrote:

On Thu, Nov 25, 2010 at 10:45 AM, Ævar Arnfjörð Bjarmason
[off-list ref] wrote:

quoted

Is there anything else than that (the builtin.h includes) that you
think needs work?

There was an issue where setting NO_GETTEXT wasn't enough to disable
internationalization. Has this been fixed?

Do you mean the issue with eval_gettext in git-sh-i18n.sh? I fixed
that issue, but even under NO_GETTEXT=YesPlease we'll still pass
things through git-sh-i18n--envsubst. Since I can't just #define
things out under NO_GETTEXT=Yes like I can in the C code.

Maybe you mean something different that I'm forgetting. But IIRC that
was the only issue.