Re: [PATCH] rebase -i: remove undocumented '--verify' flag

Thomas Rast [off-list ref] writes:

Matthieu Moy wrote:

quoted

Martin von Zweigbergk [off-list ref] writes:

quoted

Remove the undocumented and unused '--verify' flag from interactive
rebase.

I don't think this change is good. If a command has a --no-whatever
flag, one expects the --whatever flag to exist too, even if it's a
no-op.

[...]

quoted

I think a better change would be to add a comment like

--verify)
	# no-op, exists because --no-verify exists too.

Shouldn't that be

  OK_TO_SKIP_PRE_REBASE=

instead, so that it undoes the effect of an earlier --no-verify?

Yes, right. Useful when an alias contains --no-whatever in particular.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/