Hi,
On Sun, 21 Nov 2010, Jeff King wrote:
This patch clears up your bug, and doesn't break any tests. But I'd
really like to get a second opinion on the significance of those other
flags, or why the flag clearing was at the bottom of the function in the
first place.
The flag clearing was at the bottom because I had the impression that
something function one might want to call in that function in the future
could set the flags again. Maybe a goto would be appropriate here instead
of the early returns?
Ciao,
Dscho