Re: [PATCH] gitk: Add "First parent" checkbox
From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:49:59
Stefan Haller wrote:
Most of the diff related options are ones that I want to toggle with one click. That's certainly true for "Ignore space change", "First parent", and the "Diff/Old Version/New Version" radio buttons. I would hate to see any of them be removed from the diff pane.
Thanks, that's useful information. Could you give example workflows to illustrate this? Here's an example: Toggling between "Diff/Old version/New version" with a single click allows one to compare the preimage and postimage of a patch visually. It makes what changed much more obvious. Historically these have been radio buttons on the top-left part of the diff pane. If they move, it might be hard for people already familiar with gitk to find them. The preimage/postimage toggle is a useful and novel feature, and it is greedy with respect to screen real estate (a few extra diff lines can go a long way), so it would not be good to hide it in a separate "more diff options" toolbar. The case for one-click "diff against parent" is less clear. Is it that it gets toggled in practice often (i.e., avoiding pointless repetitive actions)? Hope that helps.