Thread (14 messages) flat view 14 messages, 2 authors, 2016-06-15

Re: [PATCH 8/8] Remove pack file handling dependency from wrapper.o

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:49:59

René Scharfe wrote:
Am 06.11.2010 19:42, schrieb Jonathan Nieder:
quoted
Maybe add_packed_git()?

use_pack() is called by:
[...]
quoted
some of which would make me worry about thread-safety.
Possibly, but if that's the case then we have a thread-safety issue
already: use_pack() updates pack_mapped, which is used by
release_pack_memory() to see how much can be freed.
Good point.  The threaded callers are probably protected by read_lock.

My other worry would be that try_to_free_pack_memory should not
override try_to_free_from_threads.  I guess some time documenting
these code paths will be needed. :(

Thanks for a sanity check,
Jonathan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help