Re: [PATCH v3] Porcelain scripts: Rewrite cryptic "needs update" error message

Ramkumar Ramachandra [off-list ref] writes:

Ramkumar Ramachandra writes:

quoted

Although Git interally has the facility to differentiate between
porcelain and plubmbing commands and appropriately print errors,
several shell scripts invoke plubming commands triggering cryptic
plumbing errors to be displayed on a porcelain interface. This patch
replaces the "needs update" message in git-pull and git-rebase, when
`git update-index` is run, with a more friendly message.

Reported-by: Joshua Jensen <redacted>
Reported-by: Thore Husfeldt <redacted>
Signed-off-by: Ramkumar Ramachandra <redacted>
---
 Ref: [ref] for v2.
 Ref: [ref] for v1.

 Thanks to Matthieu for reviewing v1 and Junio for reviewing v2: I've
 tried to attack the problem more conservatively in this patch. It
 doesn't list paths, and doesn't print "generic" advice.

Junio: Is this patch alright?

I did not see anything glaringly wrong in the patch offhand.  The new
messages look a bit too verbose, though.

Will queue and see what people would say.