Thread (6 messages) flat view 6 messages, 3 authors, 2016-06-15

Re: [PATCH v2] git-send-email.perl: fix In-Reply-To for second and subsequent patches

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:49:59

Possibly related (same subject, not in this thread)

Hi Antonio,

Antonio Ospite wrote:
Junio C Hamano [off-list ref] wrote:
quoted
You are breaking the && chain here.
Some other tests do that as well, the last line is a command by
itself not and-chained with the git-send-email invocation. I guess the
logic behind this is that the test succeeds if the _last_ command
succeeds. If this is wrong then some other tests are affected too.
Yes, breaking the && chain is never a good thing.

See:

 - t/README: "Chain your test assertions"
 - v1.5.4~20 (t9001: add missing && operators, 2008-01-21)
 - git log --grep=&&

Hope that helps,
Jonathan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help