Thread (9 messages) flat view 9 messages, 6 authors, 2016-06-15

Re: [PATCH] git-rebase--interactive.sh: Add new command "shell"

From: Matthieu Moy <hidden>
Date: 2016-06-15 22:49:58

Possibly related (same subject, not in this thread)

Eric Raible [off-list ref] writes:
On 11:59 AM, Yann Dirson wrote:
quoted
quoted
quoted
I'm sorry if I'm missing something, but how is this different from
"edit"?
Edit cherry-picks a commit, then exits to the shell. I needed to exit
to the shell without cherry-picking a commit.
Indeed, before "x false" was available, I had found out that "edit"
without an argument fails with a harmless error and indeed achieves that
"pause" mechanism which was really missing.

What about just fixing this so we can use "edit" ?  Do we really need
another command here ?
FWIW: +1 for edit.
I like the idea (and I won't fight for my "pause" proposal if others
don't find it intuitive), but I'm wondering how to write the quick
documentation (in the todo-list). And if we don't find a concise way
to document it, it may reveal that it's a bad idea ...

Maybe:

#  e <commit>, edit <commit> = use commit, but stop for amending
#  e, edit = stop for amending

but I find this rather ugly.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help