Re: [PATCH] git-rebase--interactive.sh: Add new command "shell"

On Thu, Nov 4, 2010 at 09:53, Kevin Ballard [off-list ref] wrote:

On Nov 4, 2010, at 1:42 AM, Matthieu Moy wrote:

quoted

Kevin Ballard [off-list ref] writes:

quoted

Add a new command "shell", which takes an option commit. It simply exits
to the shell with the commit (if given) and a message telling the user how
to resume the rebase.

"shell" sounds like you're going to execute something in a shell, not
that you're going back to the shell. Looking at the commit message, I
thought you had missed the "exec" command and re-implemented it.

What about "pause", abbreviated as "p" for the command name?

That sounds like a reasonable suggestion, except "p" is already taken by "pick".
I suppose this command could simply omit the short version.

I thought "shell" would do exactly what your patch does. And it has
the "s" short version.

So +1 for "shell" from me and -1 for "pause", which *does* confuse me.
I'd expect that
to just sleep for a few seconds.