Re: [PATCH] Add support in sample hook script for denying annotated tags.
From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:49:57
Hi, Boyd Stephen Smith Jr. wrote:
Signed-off-by: "Boyd Stephen Smith Jr." <redacted> --- templates/hooks--update.sample | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) In one project I'm in we are using a centralized Git repository that many developers have access to. As such, we want to prevent tags from being created by push operations and have them created by the administrators. This is a modification to the sample update hook to allow this to simply be a configuration option.
This kind of justification belongs above the "---", I think. No opinion on the functionality itself. Just:
quoted hunk ↗ jump to hunk
--- a/templates/hooks--update.sample +++ b/templates/hooks--update.sample@@ -7,6 +7,9 @@ # # Config # ------ +# hooks.allowannotated +# This boolean sets whether annotated tags will be allowed into the +# repository. By default they won't be.
hooks.denyannotated (defaulting to false) would be more consistent with hooks.denycreatebranch, no? Or maybe hooks.denycreatetag --- a situation in which unannotated tags should be allowed but annotated denied seems hard to imagine. Hope that helps, Jonathan