Re: git merge-tree segfault
From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2016-06-15 22:49:57
On Thu, Oct 28, 2010 at 20:16, Klas Lindberg [off-list ref] wrote:
I haven't tried this on newer versions of git, but the release notes for later releases don't mention merge-tree anywhere, so...
Doesn't segfault for me. Probably since my version has this commit:
commit 21baa6e0c56d229866c02c4b42b8b53af648d853
Author: Will Palmer [off-list ref]
Date: Wed Jul 14 18:04:07 2010 +0100
merge-tree: fix where two branches share no changes
15b4f7a (merge-tree: use ll_merge() not xdl_merge(), 2010-01-16)
introduced a regression to merge-tree to cause it to segfault when merging
files which existed in one branch, but not in the other or in the
merge-base. This was caused by referencing entry->path at a time when
entry was known to be possibly-NULL.
To correct the problem, we save the path of the entry we came in with,
as the path should be the same among all the stages no matter which
sides are involved in the merge.
Signed-off-by: Will Palmer [off-list ref]
Signed-off-by: Junio C Hamano [off-list ref]
$ git tag --contains 21baa6e0c56d229866c02c4b42b8b53af648d853|grep ^v
v1.7.2
v1.7.2.1
v1.7.2.2
v1.7.2.3
v1.7.2.3.msysgit.0
v1.7.3
v1.7.3-rc0
v1.7.3-rc1
v1.7.3-rc2
v1.7.3.1
v1.7.3.1.msysgit.0
v1.7.3.2
v1.7.3.2.msysgit.0