Re: [PATCH] CodingGuidelines: add a note to help contributors catch some errors earlier.

On Sat, Oct 23, 2010 at 03:11:19PM -0200, Thiago Farina wrote:

On Sat, Oct 23, 2010 at 12:17 PM, Yann Dirson [off-list ref] wrote:

quoted

+ - C code is expected to compile when the build is launched with the
+   following command:
+
+   make CFLAGS="-Wall -Wdeclaration-after-statement -Werror"

Why this is not in the Makefile by default? Also -Wall is already in
the Makefile.

CFLAGS seems to be used for more than gcc, and -Wall seems to be
portable enough to be overriden only in a couple of cases.  It would
not be the same for those flags.

Also note that -Wdeclaration-after-statement is also mentionned in
SubmittingPatches, but I still think it is a better place in
CodingGuidelines, which contributers are most likely to use as a
checklist before publishing.