[PATCH] Fix to push --progress. The --progress flag was not being passed into tranport.c from send-pack.h, making the --progress flag unusable · Chase Brammer <hidden> · 2016-06-15
Re: [PATCH] Fix to push --progress. The --progress flag was not being passed into tranport.c from send-pack.h, making the --progress flag unusable · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH] Fix to push --progress. The --progress flag was not being passed into tranport.c from send-pack.h, making the --progress flag unusable · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH 0/3] fix push --progress over file://, git://, etc. · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH 1/3] t5523-push-upstream: add function to ensure fresh upstream repo · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH 2/3] t5523-push-upstream: test progress messages · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH 3/3] push: pass --progress down to git-pack-objects · Tay Ray Chuan <hidden> · 2016-06-15
Re: [PATCH 3/3] push: pass --progress down to git-pack-objects · Tay Ray Chuan <hidden> · 2016-06-15
Re: [PATCH 3/3] push: pass --progress down to git-pack-objects · Jeff King <hidden> · 2016-06-15
Re: [PATCH 1/3] t5523-push-upstream: add function to ensure fresh upstream repo · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH 0/3] fix push --progress over file://, git://, etc. · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH v2 0/8] fix push --progress over file://, git://, etc. · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH v2 1/8] tests: factor out terminal handling from t7006 · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH v2 2/8] tests: test terminal output to both stdout and stderr · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH v2 3/8] test-lib: allow test code to check the list of declared prerequisites · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH v2 4/8] test_terminal: catch use without TTY prerequisite · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH v2 5/8] test_terminal: give priority to test-terminal.perl usage · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH v2 6/8] t5523-push-upstream: add function to ensure fresh upstream repo · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH v2 7/8] t5523-push-upstream: test progress messages · Tay Ray Chuan <hidden> · 2016-06-15
[PATCH v2 8/8] push: pass --progress down to git-pack-objects · Tay Ray Chuan <hidden> · 2016-06-15
Re: [PATCH v2 7/8] t5523-push-upstream: test progress messages · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v2 5/8] test_terminal: give priority to test-terminal.perl usage · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v2 5/8] test_terminal: give priority to test-terminal.perl usage · Jeff King <hidden> · 2016-06-15
Re: [PATCH v2 0/8] fix push --progress over file://, git://, etc. · Jonathan Nieder <hidden> · 2016-06-15
[PATCH 0/3] more push progress tests · Jeff King <hidden> · 2016-06-15
[PATCH 1/3] tests: factor out terminal handling from t7006 · Jeff King <hidden> · 2016-06-15
Re: [PATCH 1/3] tests: factor out terminal handling from t7006 · Jonathan Nieder <hidden> · 2016-06-15
[PATCH 2/3] tests: test terminal output to both stdout and stderr · Jeff King <hidden> · 2016-06-15
Re: [PATCH 2/3] tests: test terminal output to both stdout and stderr · Jonathan Nieder <hidden> · 2016-06-15
[PATCH 3/3] t5523: test push progress output to tty · Jeff King <hidden> · 2016-06-15
Re: [PATCH 3/3] t5523: test push progress output to tty · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH 3/3] t5523: test push progress output to tty · Jeff King <hidden> · 2016-06-15
[PATCH/RFC 0/2] test_terminal: check that TTY prerequisite is declared · Jonathan Nieder <hidden> · 2016-06-15
[PATCH 1/2] test-lib: allow test code to check the list of declared prerequisites · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH 1/2] test-lib: allow test code to check the list of declared prerequisites · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
Re: [PATCH 1/2] test-lib: allow test code to check the list of declared prerequisites · Jonathan Nieder <hidden> · 2016-06-15
[PATCH 2/2] test_terminal: catch use without TTY prerequisite · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH/RFC 0/2] test_terminal: check that TTY prerequisite is declared · Jeff King <hidden> · 2016-06-15
Re: [PATCH/RFC 0/2] test_terminal: check that TTY prerequisite is declared · Tay Ray Chuan <hidden> · 2016-06-15

Re: [PATCH v2 7/8] t5523-push-upstream: test progress messages

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:49:48

Tay Ray Chuan wrote:

[...]

quoted hunk ↗ jump to hunk

--- a/t/t5523-push-upstream.sh
+++ b/t/t5523-push-upstream.sh

@@ -70,4 +71,41 @@ test_expect_success 'push -u HEAD' '
 	check_config headbranch upstream refs/heads/headbranch
 '
 
+test_expect_success TTY 'progress messages go to tty' '
+	ensure_fresh_upstream &&
+
+	test_terminal git push -u upstream master >out 2>err &&
+	grep "Writing objects" err
+'

Thanks for testing the usual case.  It is easy to forget sometimes.

The tests using the TTY prerequisite would need to use TTYREDIR
unless we simplify the latter out of existence.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help