Re: [PATCH] CodingGuidelines: Fix a typo
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:49:44
Subsystem:
documentation, the rest · Maintainers:
Jonathan Corbet, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH] CodingGuidelines: Fix a typo · <hidden>
- 2016-06-15 · Re: [PATCH] CodingGuidelines: Fix a typo · Jonathan Nieder <hidden>
- 2016-06-15 · Re: [PATCH] CodingGuidelines: Fix a typo · Štěpán Němec <hidden>
Jonathan Nieder [off-list ref] writes:
stepnem@gmail.com wrote:quoted
`${parameter/pattern/string}' shell expansion uses glob patterns, so talking about `regexp' is confusing.Okay.quoted
- - No regexp ${parameter/pattern/string}. + - No substitution ${parameter/pattern/string}.A bit confusing, since ${parameter%word} and $parameter are substitutions, too.
I had the same reaction. Perhaps moving other parameter substitions closer to these two would help? Side note: this is totally unrelated, but the below is --patience; our output without --patience is almost unreadable in this case. Documentation/CodingGuidelines | 27 +++++++++++++++------------ 1 files changed, 15 insertions(+), 12 deletions(-)
diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
index 8346c19..09ffc46 100644
--- a/Documentation/CodingGuidelines
+++ b/Documentation/CodingGuidelines@@ -35,11 +35,22 @@ For shell scripts specifically (not exhaustive): properly nests. It should have been the way Bourne spelled it from day one, but unfortunately isn't. - - We use ${parameter-word} and its [-=?+] siblings, and their - colon'ed "unset or null" form. + - We use POSIX compliant parameter substitutions and avoid bashisms; + namely: - - We use ${parameter#word} and its [#%] siblings, and their - doubled "longest matching" form. + - We use ${parameter-word} and its [-=?+] siblings, and their + colon'ed "unset or null" form. + + - We use ${parameter#word} and its [#%] siblings, and their + doubled "longest matching" form. + + - No "Substring Expansion" ${parameter:offset:length}. + + - No shell arrays. + + - No strlen ${#parameter}. + + - No pattern replacement ${parameter/pattern/string}. - We use Arithmetic Expansion $(( ... )).
@@ -47,14 +58,6 @@ For shell scripts specifically (not exhaustive): of them, as some shells do not grok $((x)) while accepting $(($x)) just fine (e.g. dash older than 0.5.4). - - No "Substring Expansion" ${parameter:offset:length}. - - - No shell arrays. - - - No strlen ${#parameter}. - - - No regexp ${parameter/pattern/string}. - - We do not use Process Substitution <(list) or >(list). - We prefer "test" over "[ ... ]".