Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

Re: git diff --check always shows line 1 for blank at EOF for new files

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:49:43

Hi Christoph,

Christoph Mallon wrote:
  git init test
  cd test
  printf 'a\nb\nc\n\n' > file
  git add -AN
  git diff --check

The last command will show "file:1: new blank line at EOF.".

It works fine, if the diff is not against /dev/null, e.g.:
  git init test
  cd test
  printf 'a\nb\nc\n' > file
  git add -A
  echo >> file
  git diff --check

This correctly shows "file:4: new blank line at EOF.".
Try this:

    git init test
    cd test
    printf 'a\nb\nc\n' > file
    git add -A
    echo hello >> file
    echo >> file
    git diff --check

As you can see, it still returns line 4, which is the beginning of the
hunk that adds the blank line.

A change to make it print the line number of the blank line itself
does not sound so bad, though.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help