Thread (23 messages) 23 messages, 6 authors, 2016-06-15

[RFC PATCH v4 0/4] Detection of directory renames

STALE3763d

From: Yann Dirson <hidden>
Date: 2016-06-15 22:49:41

Revision v4 of 6 in this series.

Revisions (6)
  1. v2 [diff vs current]
  2. v3 [diff vs current]
  3. v4 current
  4. v5 [diff vs current]
  5. v6 [diff vs current]
  6. v7 [diff vs current]
At last a reroll of that old series.  The most prominent change is a
split of the old --factorize-renames flag into --detect-dir-renames
and --hide-dir-rename-details - hopefully following Junio's comments
dated nearly 2 years ago.  While doing this, a couple of testcases got
added (as well as a list of more testcases to be written), and some
minor optimizations were done, but no heavy surgery.

I hope we can turn the simple detection feature to something
acceptable for inclusion - that is, once unified diff output shows the
detected renames as annotations, and once the known major holes are
plugged (both from FIXME and testcases).  For the "hiding" one OTOH, a
more precise description of what we want must probably be done before
progressing, but I suggest we keep that for later.

Also, maybe the --detect-dir-renames would get a good alias as "-M -M".

Does all of that look reasonable ?

Yann Dirson (4):
  Introduce wholesame directory move detection in diffcore.
  Add testcases for the --detect-dir-renames diffcore flag.
  Allow hiding renames of individual files involved in a directory
    rename.
  Add testcases for the --hide-dir-rename-details diffcore flag.

 diff-lib.c                       |    6 +-
 diff.c                           |   12 +
 diff.h                           |    6 +
 diffcore-rename.c                |  316 +++++++++++++++++++++++++++-
 diffcore.h                       |    1 +
 t/t4046-diff-rename-factorize.sh |  433 ++++++++++++++++++++++++++++++++++++++
 tree-diff.c                      |    4 +-
 7 files changed, 766 insertions(+), 12 deletions(-)
 create mode 100755 t/t4046-diff-rename-factorize.sh

-- 
1.7.2.3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help