Re: [PATCH/RFC v3 2/8] Makefile & configure: add a NO_FNMATCH_CASEFOLD flag
From: Johannes Sixt <hidden>
Date: 2016-06-15 22:49:40
On Sonntag, 3. Oktober 2010, Ævar Arnfjörð Bjarmason wrote:
quoted hunk ↗ jump to hunk
@@ -1350,6 +1354,11 @@ ifdef NO_FNMATCH COMPAT_CFLAGS += -DNO_FNMATCH COMPAT_OBJS += compat/fnmatch/fnmatch.o endif +ifdef NO_FNMATCH_CASEFOLD + COMPAT_CFLAGS += -Icompat/fnmatch + COMPAT_CFLAGS += -DNO_FNMATCH_CASEFOLD + COMPAT_OBJS += compat/fnmatch/fnmatch.o +endif
I think you should protect against defining both NO_FNMATCH and NO_FNMATCH_CASEFOLD (your version would link compat/fnmatch/fnmatch.o twice in this case): ifdef NO_FNMATCH ... else ifdef NO_FNMATCH_CASEFOLD ... endif endif Otherwise, the patch looks fine. -- Hannes