[PATCH 7/7] commit-tree: free commit message before exiting
From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:49:40
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH 7/7] commit-tree: free commit message before exiting · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH 7/7] commit-tree: free commit message before exiting · Jonathan Nieder <hidden>
- 2016-06-15 · Re: [PATCH 7/7] commit-tree: free commit message before exiting · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH 7/7] commit-tree: free commit message before exiting · Jonathan Nieder <hidden>
This buffer is freed by the C runtime when commit-tree exits moments later, but freeing it explicitly should hopefully make this code easier to reuse (in addition to making valgrind quieter). Signed-off-by: Jonathan Nieder <redacted> --- That's the end of the series. Thanks for reading. builtin/commit-tree.c | 12 +++++++----- 1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/builtin/commit-tree.c b/builtin/commit-tree.c
index 87f0591..732f895 100644
--- a/builtin/commit-tree.c
+++ b/builtin/commit-tree.c@@ -56,10 +56,12 @@ int cmd_commit_tree(int argc, const char **argv, const char *prefix) if (strbuf_read(&buffer, 0, 0) < 0) die_errno("git commit-tree: failed to read"); - if (!commit_tree(buffer.buf, tree_sha1, parents, commit_sha1, NULL)) { - printf("%s\n", sha1_to_hex(commit_sha1)); - return 0; - } - else + if (commit_tree(buffer.buf, tree_sha1, parents, commit_sha1, NULL)) { + strbuf_release(&buffer); return 1; + } + + printf("%s\n", sha1_to_hex(commit_sha1)); + strbuf_release(&buffer); + return 0; }
--
1.7.2.3