Re: [PATCH v2 1/2] sh-setup: Write a new require_clean_work_tree function
From: Ramkumar Ramachandra <hidden>
Date: 2016-06-15 22:49:40
Subsystem:
documentation, the rest · Maintainers:
Jonathan Corbet, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH v2 1/2] sh-setup: Write a new require_clean_work_tree function · Ramkumar Ramachandra <hidden>
- 2016-06-15 · Re: [PATCH v2 1/2] sh-setup: Write a new require_clean_work_tree function · Junio C Hamano <hidden>
Hi Jonathan, Jonathan Nieder writes:
Ramkumar Ramachandra wrote:quoted
Are all these tags useful?Probably not. :)
[...] How about this then? Thanks-to: Jonathan Nieder [off-list ref] Signed-off-by: Ramkumar Ramachandra <redacted> -- 8< --
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index ece3c77..72741eb 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches@@ -264,12 +264,21 @@ the change to its true author (see (2) above). Also notice that a real name is used in the Signed-off-by: line. Please don't hide your real name. -Some people also put extra tags at the end. - -"Acked-by:" says that the patch was reviewed by the person who -is more familiar with the issues and the area the patch attempts -to modify. "Tested-by:" says the patch was tested by the person -and found to have the desired effect. +If you like, you can put extra tags at the end: + +1. "Reported-by:" is used to to credit someone who found the bug that + the patch attempts to fix. +2. "Acked-by:" says that the person who is more familiar with the area + the patch attempts to modify liked the patch. +3. "Reviewed-by:", unlike the other tags, can only be offered by the + reviewer and means that she is completely satisfied that the patch + is ready for application. It is usually offered only after a + detailed review. +4. "Tested-by:" is used to indicate that the person applied the patch + and found it to have the desired effect. + +You can also create your own tag or use one that's in common usage +such as "Thanks-to:", "Based-on-patch-by:", or "Mentored-by:". ------------------------------------------------ An ideal patch flow