[PATCHv4 00/15] Add missing &&'s in the testsuite · Elijah Newren <hidden> · 2016-06-15
[PATCHv4 04/15] t4002 (diff-basic): use test_might_fail for commands that might fail · Elijah Newren <hidden> · 2016-06-15
Re: [PATCHv4 04/15] t4002 (diff-basic): use test_might_fail for commands that might fail · Jonathan Nieder <hidden> · 2016-06-15
[PATCHv4 06/15] t3600 (rm): add lots of missing && · Elijah Newren <hidden> · 2016-06-15
Re: [PATCHv4 06/15] t3600 (rm): add lots of missing && · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCHv4 06/15] t3600 (rm): add lots of missing && · Elijah Newren <hidden> · 2016-06-15
[PATCHv4 03/15] t100[12] (read-tree-m-2way, read_tree_m_u_2way): add missing && · Elijah Newren <hidden> · 2016-06-15
[PATCHv4 01/15] t3020 (ls-files-error-unmatch): remove stray '1' from end of file · Elijah Newren <hidden> · 2016-06-15
[PATCHv4 02/15] t4017 (diff-retval): replace manual exit code check with test_expect_code · Elijah Newren <hidden> · 2016-06-15
[PATCHv4 07/15] t4019 (diff-wserror): add lots of missing && · Elijah Newren <hidden> · 2016-06-15
Re: [PATCHv4 07/15] t4019 (diff-wserror): add lots of missing && · Jonathan Nieder <hidden> · 2016-06-15
[PATCHv4 09/15] t5602 (clone-remote-exec): add missing && · Elijah Newren <hidden> · 2016-06-15
[PATCHv4 08/15] t4026 (color): remove unneeded and unchained command · Elijah Newren <hidden> · 2016-06-15
[PATCHv4 15/15] Replace "unset VAR" with "unset VAR;" in testsuite as per t/README · Elijah Newren <hidden> · 2016-06-15
[PATCHv4 11/15] t7001 (mv): add missing && · Elijah Newren <hidden> · 2016-06-15
[PATCHv4 10/15] t6016 (rev-list-graph-simplify-history): add missing && · Elijah Newren <hidden> · 2016-06-15
Re: [PATCHv4 10/15] t6016 (rev-list-graph-simplify-history): add missing && · Jonathan Nieder <hidden> · 2016-06-15
[PATCHv4 12/15] t7601 (merge-pull-config): add missing && · Elijah Newren <hidden> · 2016-06-15
[PATCHv4 13/15] t7800 (difftool): add missing && · Elijah Newren <hidden> · 2016-06-15
Re: [PATCHv4 13/15] t7800 (difftool): add missing && · Jonathan Nieder <hidden> · 2016-06-15
[PATCHv4 05/15] t4202 (log): Replace '<git-command> || :' with test_might_fail · Elijah Newren <hidden> · 2016-06-15
[PATCHv4 14/15] Add missing &&'s throughout the testsuite · Elijah Newren <hidden> · 2016-06-15
Re: [PATCHv4 14/15] Add missing &&'s throughout the testsuite · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
Re: [PATCHv4 14/15] Add missing &&'s throughout the testsuite · Jonathan Nieder <hidden> · 2016-06-15

Re: [PATCHv4 14/15] Add missing &&'s throughout the testsuite

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2016-06-15 22:49:40

On Sun, Sep 26, 2010 at 23:14, Elijah Newren [off-list ref] wrote:

 test_expect_success 'did not use upload-pack service' '
-       grep '/git-upload-pack' <"$HTTPD_ROOT_PATH"/access.log >act
-       : >exp
+       grep '/git-upload-pack' <"$HTTPD_ROOT_PATH"/access.log >act &&
+       >exp &&
       test_cmp exp act
 '

This test started failing in pu, I'm presuming you didn't spot it
since you didn't run the tests with GIT_TEST_HTTPD=1.

Anyway, that grep should be a "! grep" to work with &&.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help