Thread (11 messages) flat view 11 messages, 3 authors, 2016-06-15

Re: [PATCH v2 1/3] Add bidirectional_transfer_loop()

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:49:39

Ilari Liusvaara wrote:
quoted hunk ↗ jump to hunk
--- a/transport-helper.c
+++ b/transport-helper.c
[...]
+	if (!in_hup && inbufuse < BUFFERSIZE) {
+		stdin_index = nextindex++;
+		polls[stdin_index].fd = 0;
+		transfer_debug("Adding stdin to fds to wait for");
Why not:

		trace_printf("trace: adding stdin to ...");

?  That would give the user control of where tracing output goes
(settings like GIT_TRACE=17).

If trace is too noisy (I don't think it is), maybe we should
make it more nuanced, like GIT_TRACE=17:transport?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help