[PATCH v4 0/4] rev-parse: allow --flags to output rev-parse-like flags · Jon Seymour <hidden> · 2016-06-15
[PATCH v4 1/4] rev-parse: stop interpreting flags as options to rev-parse once --flags is specified · Jon Seymour <hidden> · 2016-06-15
[PATCH v4 2/4] rev-parse: add tests for git rev-parse --flags. · Jon Seymour <hidden> · 2016-06-15
Re: [PATCH v4 2/4] rev-parse: add tests for git rev-parse --flags. · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
Re: [PATCH v4 2/4] rev-parse: add tests for git rev-parse --flags. · Jon Seymour <hidden> · 2016-06-15
[PATCH v4 3/4] rev-parse: update documentation of --flags and --no-flags options · Jon Seymour <hidden> · 2016-06-15
[PATCH v4 4/4] rev-parse: make --flags imply --no-revs for remaining arguments. · Jon Seymour <hidden> · 2016-06-15
Re: [PATCH v4 4/4] rev-parse: make --flags imply --no-revs for remaining arguments. · Jon Seymour <hidden> · 2016-06-15

Re: [PATCH v4 2/4] rev-parse: add tests for git rev-parse --flags.

From: Jon Seymour <hidden>
Date: 2016-06-15 22:49:37

On Sun, Sep 26, 2010 at 12:27 AM, Ævar Arnfjörð Bjarmason
[off-list ref] wrote:

On Sat, Sep 25, 2010 at 13:33, Jon Seymour [off-list ref] wrote:

quoted

+       : >expected &&

We've been dropping the ":>foo" style in favor of ">foo" in other
tests. There's no need for the ":".

quoted

+       echo -X > expected &&
+       echo -q > expected &&
+       echo -X > expected &&
+       echo --no-flags > expected &&

Maybe some echo implementations don't like flag-like params, and we need:

   printf "%s\n" "-X"

here. I don't know whether that's the case.

Thanks for the review.

My latest revision incorporates this feedback, although I didn't use
extra quotes around -X. (e.g. I wrote printf "%s\n" -X)

jon.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help