Re: [PATCH] t/t3903-stash: improve testing of git-stash show

On 09/24/2010 03:43 PM, Brian Gernhardt wrote:

quoted

On 09/24/2010 03:27 PM, Brian Gernhardt wrote:

quoted

I bisected the issue to a9bf09e (detached-stash: simplify git stash show),
which is when "git stash show" started using parse_flags_and_rev (via
assert_stash_like()).

More worrying to me is that the tests for "git stash show" don't bother
to test the output.  I'll be working on that now.

I was preparing these tests when your email came in.

I spent longer finding the source of the problem than you did.  I was just
putting the finishing touches on it when I got this.  Yours is more through
than mine, so I won't bother finishing.

I hope you're just abandoning the tests you were creating, and _not_
abandoning the search for a fix.  The "solution" I offered is flawed
and breaks some of the other tests. :)

-Brandon