Re: [PATCH] t7003: Use test_commit instead of custom function

On Mon, Sep 13, 2010 at 15:44, Johannes Schindelin
[off-list ref] wrote:

Hi,

On Mon, 13 Sep 2010, Ævar Arnfjörð Bjarmason wrote:

quoted

On Mon, Sep 13, 2010 at 15:24, Brian Gernhardt
[off-list ref] wrote:

quoted

On Sep 13, 2010, at 8:11 AM, Ævar Arnfjörð Bjarmason [off-list ref] wrote:

quoted

In addition, why do we need a custom make_commit when we have
test_commit in test-lib.sh?

It was added in v1.5.3-rc0~69^2~10 by Johannes Schindelin (CC'd). It's
probably just now-needless duplication, but I haven't familirized myself
with the code.

Yep, I did not make a cleanup patch after adding test_commit. Neither did
I consolidate other cases in t/ where the steps are done explicitly.

Thanks. I didn't check when test_commit was added, it makes sense now.

There's a lot of old spiderwebs like that in t/* that could now use
cleanup.