davi.reis@gmail.com writes:
Subject: Re: [PATCH 1/2] Do not let lstree output recursively when a directory whose name is a prefix of the others is give
Don't try to put everything in the subject line. The subject line
should be < 80 characters (fit in a standard terminal), and it's best
if commands like "git log --oneline" & friends can show it without
truncating it, hence, ~50-60 characters is good.
What about
ls-tree: do not recurse when a directory is a prefix of another
<then, a more detailed description, after a blank line>
(I don't know the code of ls-tree, and I don't really understand
either the bug or the fix by reading this. A good commit message help
people to get convinced that your code is good)
From: Davi Reis <redacted>
If you use the same identifier for the commit and when you send the
email, you'll get rid of this « From » in the body. I don't think you
want this davi-macbookpro.local to appear publicly indeed.
You don't have a Signed-Off-By:, please read
Documentation/SubmittingPatches to see how to add it and what it
means.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/