[PATCH 00/20] [CONTINUE] Add gettext support to Git · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
[PATCH 01/20] gettextize: git-clean clean.requireForce braces · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
[PATCH 02/20] gettextize: git-clone "Cloning into" message braces · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
[PATCH 04/20] Makefile: add GNU_GETTEXT, set when we expect GNU gettext · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
[PATCH 07/20] gettextize: git-revert "Your local changes" message · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
[PATCH 05/20] Makefile: MSGFMT="msgfmt --check" under GNU_GETTEXT · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
[PATCH 06/20] Revert "gettextize: git-revert mark the "me" variable for translation" · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
[PATCH 09/20] gettext: add GETTEXT_POISON support for shell scripts · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
[PATCH 11/20] gettextize: git-am add git-sh-i18n · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
[PATCH 10/20] gettext: add GETTEXT_POISON tests for shell scripts · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
[PATCH 12/20] gettextize: git-am one-line gettext $msg; echo · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
[PATCH 13/20] gettextize: git-am multi-line getttext $msg; echo · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
[PATCH 19/20] gettextize: git-am core say messages · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
[PATCH 08/20] gettextize: git-revert literal "me" messages · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
[PATCH 17/20] gettextize: git-am clean_abort messages · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
[PATCH 15/20] gettextize: git-am die messages · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
[PATCH 16/20] gettextize: git-am cannot_fallback messages · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
[PATCH 18/20] gettextize: git-am "Apply?" message · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
[PATCH 14/20] gettextize: git-am eval_gettext messages · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
[PATCH 20/20] gettextize: git-am printf(1) message to eval_gettext · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
Re: [PATCH 20/20] gettextize: git-am printf(1) message to eval_gettext · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH 20/20] gettextize: git-am printf(1) message to eval_gettext · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
Re: [PATCH 20/20] gettextize: git-am printf(1) message to eval_gettext · Jonathan Nieder <hidden> · 2016-06-15
[PATCH v2 20/20] gettextize: git-am printf(1) message to eval_gettext · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15
[PATCH v2 19/20] gettextize: git-am core say messages · Ævar Arnfjörð Bjarmason <hidden> · 2016-06-15

Re: [PATCH 20/20] gettextize: git-am printf(1) message to eval_gettext

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:49:30

Hi,

Ævar Arnfjörð Bjarmason wrote:

quoted hunk ↗ jump to hunk

+++ b/git-am.sh

@@ -778,7 +778,7 @@ did you forget to use 'git add'?"; echo

       fi
       if test $apply_status != 0
       then
-               printf 'Patch failed at %s %s\n' "$msgnum" "$FIRSTLINE"
+               echo "$(eval_gettext "Patch failed at \$msgnum \$FIRSTLINE")"

Probably I am missing something silly, but why not just:

        eval_gettext 'Patch failed at $msgnum $FIRSTLINE\n'

? I ask because it is nice to be able to avoid "echo" with arbitrary
data: special characters (e.g. \) can make for portability hassles.

Jonathan

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help