Re: [RFC/PATCH] Force using Tcl/Tk 8.4 on Mac OS X
From: Pat Thoyts <hidden>
Date: 2016-06-15 22:49:30
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [RFC/PATCH] Force using Tcl/Tk 8.4 on Mac OS X · Stefan Haller <hidden>
- 2016-06-15 · Re: [RFC/PATCH] Force using Tcl/Tk 8.4 on Mac OS X · Daniel A. Steffen <hidden>
- 2016-06-15 · Re: [RFC/PATCH] Force using Tcl/Tk 8.4 on Mac OS X · Stefan Haller <hidden>
"Daniel A. Steffen" [off-list ref] writes:
Hi Stefan, On Sep 6, 2010, at 10:07 AM, Stefan Haller wrote:quoted
When using Git Gui.app on a Snow Leopard system with Tcl/Tk 8.5, there are two problems: 1) Menu commands that open a dialog (e.g. "Push" or "Revert changes") don't work when invoked via their keyboard shortcuts. You get a dialog without a title bar, and the application then hangs without further responding to any user input; you need to kill it. Invoking the same commands with the mouse by choosing from the menu works fine.first time I hear of this (or see this myself, and I use git gui every day on Mac OS X); in part this may be due to the fact that many of the menu shortcuts assigned by git gui conflict with existing OS X shortcuts and don't work anyway e.g. cmd-A (esp if a text widget is in focus)... personally I would hate for my git gui to be downgraded to Tk 8.4 and Carbon because of this small issue, and I'm unlikely to be alone.
I will not force 8.4 on anyone. If someone wants to force it locally they can just edit the wish command in their git-gui script file to use wish8.4. I'm happy - even eager - to apply patches to improve the MacOSX git gui experience but I can't test them as I don't have such a system.
quoted hunk
diff --git i/git-gui.sh w/git-gui.sh index 0d5c5e3..ec7ed7d 100755 --- i/git-gui.sh +++ w/git-gui.sh@@ -2723,6 +2723,9 @@ if {[is_enabled multicommit] || [is_enabled singlecommit]} { -accelerator $M1T-J lappend disable_on_lock \ [list .mbar.commit entryconf [.mbar.commit index last] -state] + if {[is_MacOSX]} { + .mbar.commit entryconf last -accelerator {} + } .mbar.commit add separator
This removes the Cmd-J accelerator from the "Revert Changes" menu
item. I assume that just changing the menu command to
{after idle [list do_revert_selection]}
doesn't work either?
Do you want this applied or will you produce a patch that removes more
such inappropriate accelerators?
Also - got any other MacOS specific patches?
--
Pat Thoyts http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD