Re: [PATCH] Add test-string-list.c

On Mon, Sep 6, 2010 at 9:07 PM, Jonathan Nieder [off-list ref] wrote:

Hi Thiago,

Thiago Farina wrote:

quoted

On Sun, Sep 5, 2010 at 2:02 AM, Jonathan Nieder [off-list ref] wrote:>

quoted

quoted

To make sure this example remains valid, wouldn't you want to include
a caller in the t/ directory so it can be automatically run?  (See
t/README.)

I read it, but I'm not sure how to do this. Maybe you could point me
to an example?

t0070-fundamental.sh might be a good place to add it.

Thanks, added it to there.

quoted

It can be expanded later by anyone to test many other things though.

I suppose.  Edge cases for arguments, sorting, and _DUP versus _NODUP
semantics would be the main thing I would be interested in testing.

Reworked into small functions to test string_list functions separated
(using assert to check if the return value of the function is what is
expected).

Please, take another look.