Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: Fix for normalization of foreign idents

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:49:30

Hi Marcus,

Marcus Comstedt wrote:
Was this patch simply forgotten, or are there some remaining
concerns about it?
I assume it is just that no one using the $ident$ feature took a
look at it, which leaves us without a sanity-check that it
consistently works and improves things.

If you have the time, a test and documentation might help (the former
plays the role of an artificial user, who can describe the feature and
will make noise if we break it with future changes).
Should I submit a new patch which simply fixes the inconsistency
which breaks checkout, and leaves the removal of foreign idents
on commit to user interaction or hook scripts, as suggested by
Jonathan?  That would at least restore deterministic behavior...
That doesn't sound necessary to me.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help