Re: [PATCH/RFC] Restructure some of the checkout opts.

Jens Lehmann [off-list ref] writes:

Am 05.09.2010 14:09, schrieb Jared Hance:

quoted

Previously, most opts in `builtin.checkout.c' had been an instance of
`struct checkout_opts'. It appears that some of the opts that were
perhaps added later were not in the struct. Move them into the struct
in order to maintain consistency.

Hm, they aren't used outside of cmd_checkout() (as the other members
are), so maybe it is ok that they aren't in the struct?

Correct.  I do not think they are outside the structure because they are
overlooked.

They simply do not make sense outside the context of "builtin/checkout.c"
where "struct checkout" is used (e.g. what would patch-mode possibly mean
in the context of "builtin/apply" where the struct is used to check out a
path that is not checked out to the working tree).  Moving them into the
structure would thus make no sense and _will_ confuse people.