Re: [PATCH 1/3 v2] tests: factor HOME=$(pwd) in test-lib.sh

On Wed, Sep 1, 2010 at 15:24, Junio C Hamano [off-list ref] wrote:

Ævar Arnfjörð Bjarmason [off-list ref] writes:

quoted

On Tue, Aug 31, 2010 at 07:42, Ævar Arnfjörð Bjarmason [off-list ref] wrote:

quoted

On Mon, Aug 30, 2010 at 23:15, Matthieu Moy [off-list ref] wrote:

quoted

The same pattern is used in many tests, and makes it easy for new ones to
rely on $HOME being a trashable, clean, directory.

Signed-off-by: Matthieu Moy <redacted>
---
Just re-ordered the patch to make this one the first.

I took Ævar's suggestion of using $TRASH_DIRECTORY instead of $(pwd).

Thanks,

Acked-by: Ævar Arnfjörð Bjarmason <redacted>

Junio: FYI you picked up v1 of this for next/pu, not this v2.

I know.

The originals all used $(pwd) as far as I saw, and it _is_ more faithful
and correct refactoring not to use $TRASH_DIRECTORY in this patch, no?
You can choose to change it to use $TRASH but that should be done in a
separate patch.

I just wanted to note it in case you didn't see it. It's a trivial
issue and I don't really care, I just wanted to note it in case the v2
went past you.