Re: [PATCH 2/2] tests: make test_must_fail fail on missing commands

On Tue, Aug 31, 2010 at 18:08, Jeff King [off-list ref] wrote:

On Tue, Aug 31, 2010 at 12:26:57PM -0500, Jonathan Nieder wrote:

quoted

Jeff King wrote:

quoted

The point of it is to run a command that produces failure. A
missing command is more likely an error in the test script

Makes sense.  Here's the corresponding change for test_might_fail.

I think this is probably worth doing. Unless somebody is doing something
silly like:

 test_might_fail command_that_might_exist

But that seems a pretty contrived scenario (I am imagining something
like "call sync now, but if we don't have it, don't fail". But in the
test scripts that seems unlikely).

Yes, test_must_fail is only for git commands, not external stuff like
sync, although some naughty people have gone and used it for grep/test
in a few places instead of using "!" it seems.