Thread (5 messages) flat view 5 messages, 2 authors, 2016-06-15

Re: [PATCH] checkout: respect diff.ignoreSubmodules setting

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:49:23

Possibly related (same subject, not in this thread)

Jens Lehmann [off-list ref] writes:
Am 25.08.2010 12:34, schrieb Johannes Schindelin:
quoted
 ...
Let's respect that setting when 'git checkout' reports the uncommitted
changes, since it does nothing else than a 'git diff --name-status'.

Signed-off-by: Johannes Schindelin <redacted>
Thanks for fixing that!

Acked-by: Jens Lehmann <redacted>
Makes sense.

I wondered if the new parameter to show_local_changes() should just be of
type (struct checkout_opts *), so that other options given to checkout,
not necessarily related to the diff generation, can influence the output
further if we wanted to, but that kind of change can be done if and when
it becomes necessary.

Thanks.  Perhaps we would want a new test or two in t2013?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help