Thread (6 messages) 6 messages, 3 authors, 2016-06-15

Re: [RFC/PATCH] Add test case for dealing with a tracked file in an ignored directory

flat view

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:49:23
Subsystem: the rest · Maintainer: Linus Torvalds

Possibly related (same subject, not in this thread)

Ævar Arnfjörð Bjarmason wrote:
I just try to
(hopefully mostly helpfully) to point out common things that
contradict the docs we have
Thanks for doing so, by the way.  One of the best ways to make sure
the docs are sane is to use them.

When a guideline is unclear, probably I should have been updating the
docs instead of dispensing advice.

How about something like this?
diff --git a/t/README b/t/README
index 410499a..f347de7 100644
--- a/t/README
+++ b/t/README
@@ -235,7 +235,9 @@ Do's, don'ts & things to keep in mind
 -------------------------------------
 
 Here are a few examples of things you probably should and shouldn't do
-when writing tests.
+when writing tests.  If you are editing an existing test script and have
+the time for it, consider updating the script to follow these guidelines
+in a separate patch before adding your new test.
 
 Do:
 
-- 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help