On Aug 23, 2010, at 11:05 PM, Jonathan Nieder wrote:
While we're looking at this test script, some more nitpicks for
squashing in. :)
-- 8< --
Subject: t7610 (mergetool): more nitpicks
- use tabs to indent
- do not redirect output away unnecessarily
- avoid a subshell for 'yes "" | git mergetool file3'
- use test_tick for reproducible, increasing timestamps
- use test_cmp instead of 'test $foo = bar'; the former is much
nicer to debug with --verbose since it produces a diff.
Fair enough. I just took a stab at the bit that irritated me the most. Thanks for cleaning up the rest.
~~ Brian