Thread (8 messages) flat view 8 messages, 4 authors, 2016-06-15

Re: [PATCH] t7610: cd inside subshell instead of around

From: Brian Gernhardt <hidden>
Date: 2016-06-15 22:49:22

On Aug 23, 2010, at 11:05 PM, Jonathan Nieder wrote:
While we're looking at this test script, some more nitpicks for
squashing in. :)

-- 8< --
Subject: t7610 (mergetool): more nitpicks

- use tabs to indent
- do not redirect output away unnecessarily
- avoid a subshell for 'yes "" | git mergetool file3'
- use test_tick for reproducible, increasing timestamps
- use test_cmp instead of 'test $foo = bar'; the former is much
  nicer to debug with --verbose since it produces a diff.
Fair enough.  I just took a stab at the bit that irritated me the most.  Thanks for cleaning up the rest.

~~ Brian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help