Re: [RFC/PATCH] commit: update the index after running the pre-commit hook

Ævar Arnfjörð Bjarmason  [off-list ref] writes:

Change git-commit to update the index after running the pre-commit
hook, but before it constructs the comments that'll accompany the
commit message displayed in the $EDITOR.

Hmm.

I have always thought that "pre-commit" is about verification, just like
other pre-anything hooks.  We have never sanctioned it to modify the tree,
and the document does not say the hook is allowed to.

Although I am not opposed to this patch, it is a change to the defined
semantics that is somewhat worrysome.  We probably should document what it
is and is not allowed to a bit better.