Thread (30 messages) flat view 30 messages, 5 authors, 2016-06-15
DORMANTno replies

[PATCH 2/2] t7006 (pager): add missing TTY prerequisite

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:49:19
Subsystem: the rest · Maintainer: Linus Torvalds

Possibly related (same subject, not in this thread)

The config pagination test should not run if there is not a tty
available to force pagination on.

Reported-by: Thomas Rast <redacted>
Signed-off-by: Jonathan Nieder <redacted>
---
This one fixes for “config: run setup_git_directory_gently()
sooner”.

Thanks again for the report.  I’ll think more about how to make
problems like this easily reproducible (a test_mentions_prereq()
function?).

 t/t7006-pager.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t7006-pager.sh b/t/t7006-pager.sh
index fcd846a..fb744e3 100755
--- a/t/t7006-pager.sh
+++ b/t/t7006-pager.sh
@@ -134,7 +134,7 @@ test_expect_success TTY 'configuration can disable pager' '
 	! test -e paginated.out
 '
 
-test_expect_success 'git config uses a pager if configured to' '
+test_expect_success TTY 'git config uses a pager if configured to' '
 	rm -f paginated.out &&
 	git config pager.config true &&
 	test_when_finished "git config --unset pager.config" &&
-- 
1.7.2.1.544.ga752d.dirty
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help