Re: [PATCH] git-svn: fix fetch with deleted tag
flat view
From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2016-06-15 22:49:19
On Sat, Aug 14, 2010 at 14:07, David D. Kilzer [off-list ref] wrote:
+ my ($url, undef, undef) = ::cmt_metadata($max_commit);
This can just be:
my ($url) = ::cmt_metadata($max_commit);
Perl will throw the extra arguments away for you.
quoted hunk ↗ jump to hunk
+test_expect_success 'setup svn repo' ' + mkdir -p import/trunk/subdir && + mkdir -p import/branches && + mkdir -p import/tags && + echo "base" > import/trunk/subdir/file &&
Junio usually prefers the ">foo" style to "> foo".
quoted hunk ↗ jump to hunk
+ cd svn_project && + + echo "trunk change" >> subdir/file && + svn_cmd ci -m "trunk change" subdir/file && + + svn_cmd switch "$svnrepo/branches/mybranch/trunk" && + echo "branch change" >> subdir/file && + svn_cmd ci -m "branch change" subdir/file && + + cd .. &&
If you use a subshell here it'll cd back for you.
quoted hunk ↗ jump to hunk
+++ b/t/t9156-git-svn-fetch-deleted-tag-2.sh@@ -0,0 +1,45 @@ +#!/bin/sh + +test_description='git svn fetch deleted tag 2'
Any reason not to include both of these in the same file? Just to avoid having to manually reset the repository? </nitpicks>