Re: [PATCH 1/2 (fix broken test)] rebase -i: add exec command to launch a shell command

Junio C Hamano [off-list ref] writes:

Matthieu Moy [off-list ref] writes:

quoted

+# "exec" commands are ran with the user shell by default, but this may
+# be non-POSIX. For example, if SHELL=zsh then ">file" doesn't work
+# to create a file. Unseting SHELL avoids such non-portable behavior
+# in tests.
+SHELL=

Tricky but true.

Do we have other callouts that we use $SHELL from the environment?

Not as far as I know. "git grep SHELL" show mostly "SHELL_PATH", and
the testsuite passes for me with SHELL=zsh.

This exec command is a bit of a special case: I wanted the user to
keep the advanced features of his shell (for example, the ** wildcard
of zsh and recent bash), not just allow executing commands.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/