Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH 2/5] merge-recursive: porcelain messages for checkout

From: Matthieu Moy <hidden>
Date: 2016-06-15 22:49:16

Junio C Hamano [off-list ref] writes:
Matthieu Moy [off-list ref] writes:
quoted
+void set_porcelain_error_msgs(const char **msgs, const char *cmd)
 {
+	const char *msg;
+	char *tmp;
+	const char *cmd2 = strcmp(cmd, "checkout") ? cmd : "switch branches";
This may have implications to the later i18n effort, but lets ignore it
for now.  I don't think it will be too bad.
Note that the ? : construct just allows factoring out two messages,
but one can easily distinguish all cases and give the complete error
message in the source (we don't care about performance/memory here,
it's a one-time thing).

So, yes, that's easily fixable later if it causes problems to i18n.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help