Re: [PATCH 1/5] diff: parse separate options like -S foo

Jakub Narebski [off-list ref] writes:

Matthieu Moy [off-list ref] writes:

quoted

+static inline int short_opt(char opt, const char **argv,
+			    const char **optarg)

[...]

quoted

+int parse_long_opt(const char *opt, const char **argv,
+		   const char **optarg)

Just a nitpick question: why it is 'parse_long_opt' but just
'short_opt'?

I initially made *_long_opt prefixed with something (diff_ in my first
version) because it's global, while short_opt is static.
parse_short_opt is already taken in parse-option.c, so I'd rather
avoid re-using it (it's static there, so technically, we can,
but ...).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/