Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 1/5] t1011 (sparse checkout): style nitpicks

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:49:14

Junio C Hamano [off-list ref] writes:
Nguyễn Thái Ngọc Duy  [off-list ref] writes:
quoted
From: Jonathan Nieder <redacted>

Tweak the rest of the script to more closely follow the test
style guide.  Guarding setup commands with test_expect_success
makes it easy to see the scope in which some particular data is
used; removal of whitespace after >redirection operators is just
for consistency.

Signed-off-by: Jonathan Nieder <redacted>
Signed-off-by: Nguyễn Thái Ngọc Duy <redacted>
What happened to the 'test -z "$(cmd)" discards exit status from cmd' part
of Jonathan's patch?
Sorry, I was confused.

Please disregard the above; it took me a while to realize that this
5-patch series is a re-roll of what I queued, which in turn Jonathan's
nitpick is based on, and you took the advice while redoing 2/5.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help