Re: [PATCH 1/3 v4] Add a macro DIFF_QUEUE_CLEAR.

Hi Sven,
On Mon, Aug 2, 2010 at 8:47 PM, Sven Verdoolaege [off-list ref] wrote:

On Thu, May 06, 2010 at 09:52:27PM -0700, Bo Yang wrote:

quoted

Refactor the diff_queue_struct code, this macro help
to reset the structure.

[..]

quoted

diff --git a/diff.c b/diff.c
index e40c127..4a350e3 100644
--- a/diff.c
+++ b/diff.c

@@ -2540,6 +2540,7 @@ static void run_checkdiff(struct diff_filepair *p, struct diff_options *o)

 void diff_setup(struct diff_options *options)
 {
      memset(options, 0, sizeof(*options));
+     memset(&diff_queued_diff, 0, sizeof(diff_queued_diff));

Sorry about the broken code and the bad commit message...

This line is used to clear the global queue structure and make it
usable in next round of diff. I am wondering how the submodule part
use the diff API to cause such an issue. :)

-- 
Regards!
Bo
----------------------------
My blog: http://blog.morebits.org
Why Git: http://www.whygitisbetterthanx.com/