Thread (7 messages) flat view 7 messages, 2 authors, 2016-06-15
DORMANTno replies

[PATCH 0/5 v3] log and diff: accept detached forms (--option value)

From: Matthieu Moy <hidden>
Date: 2016-06-15 22:49:13

Since last version :

* I had missed several optional arguments, for which detached form
  should not be allowed (otherwise, --option --other-option is
  ambiguous). In most cases, my changes were harmless since the code
  had already checked for the parameterless form before reaching mine,
  but that was definitely bad anyway.

* One missing "return optarg;" (that even Jonathan had missed ;-) )

* One more test for "git log -S" failure (no argument to -S)

* Refactoring by Jonathan Nieder for --stat-*

* Rewording of commit messages.

Jonathan Nieder (1):
  diff: split off a function for --stat-* option parsing

Matthieu Moy (4):
  diff: parse detached options like -S foo
  diff: parse detached options --stat-width n, --stat-name-width n
  log: parse detached options like git log --grep foo
  log: parse detached option for --glob

 diff.c                       |  167 +++++++++++++++++++++++++++++++-----------
 diff.h                       |    7 ++
 revision.c                   |   79 +++++++++++++-------
 t/t4013-diff-various.sh      |    5 +
 t/t4013/diff.log_-S_F_master |    7 ++
 t/t4202-log.sh               |   19 +++--
 t/t6018-rev-list-glob.sh     |    6 ++
 7 files changed, 211 insertions(+), 79 deletions(-)
 create mode 100644 t/t4013/diff.log_-S_F_master

-- 
1.7.2.21.ge9796
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help