Re: [PATCH 2/2] Submodules: Use "ignore" settings from .gitmodules too for diff and status

Jens Lehmann [off-list ref] writes:

The .gitmodules file is parsed for "submodule.<name>.ignore" entries
before looking for them in .git/config. Thus settings found in .git/config
will override those from .gitmodules,...

Hmph.

The value of "submodule.<name>.path" does not have to be "<name>".  There
seems to be a bit of confusion here.

I thought that [PATCH 1/2] used the path to the submodule, not its name,
as the key.  Even though the patch to Documentation/config.txt talks about
"submodule.<submodulename>.ignore", what the code actually seems to do in
set-from-submodule-config is to use path.  

But this patch seems to key off of <name>.

I suspect that it would make more sense to use <name> so that once the
user configures ignore in .git/config, it will persist across moving of
the submodule in the superproject tree.

In either case, we would want to be consistent between the two, no?